deephaven / vscode-deephaven

Deephaven Visual Studio Code Extension
Apache License 2.0
3 stars 0 forks source link

fix: Pip servers handle config changes gracefully #142

Closed bmingles closed 2 months ago

bmingles commented 2 months ago

Testing I used a configuration targetting the first few ports starting at 10000

Initial config (servers all commented out)

"deephaven.coreServers": [
  // "http://localhost:10000/",
  // "http://localhost:10001/",
  // "http://localhost:10002/",

Pip server port becomes reserved via config change

Start server outside of extension

Arbitrary config change

resolves #137

github-actions[bot] commented 2 months ago

End-to-end Test Summary

Tests 📝Passed ✅Failed ❌Skipped ⏭️Pending ⏳Other ❓Flaky 🍂Duration ⏱️
660000004:59:49

A ctrf plugin

Detailed Test Results

NameStatusmsFlaky 🍂
should default to the correct settingspassed ✅1735
should return custom settings: Empty configspassed ✅293
should return custom settings: Populated configspassed ✅191
should be able to load VSCodepassed ✅1038
should only be visible when a supported file type is active: test.groovypassed ✅2783
should only be visible when a supported file type is active: test.pypassed ✅1012

A ctrf plugin

Failed Test Summary

No failed tests ✨

Flaky Test Summary

No flaky tests detected. ✨