fix: Search filtering now works in PANELS - Githubissues

deephaven / vscode-deephaven

Deephaven Visual Studio Code Extension

Apache License 2.0

3 stars 0 forks source link

fix: Search filtering now works in PANELS #177

Closed bmingles closed 3 days ago

bmingles commented 1 week ago

I fixed a bug where I was setting description instead of label that was breaking built in search / filter in the "PANELS" treeview. Also added search actions to the titlebar of CONNECTIONS + PANELS trees

Testing

from deephaven import empty_table

for i in range(100):
    print(f"Making {i}")
    globals()[f"t{i}"] = empty_table(10).update(['X = i', 'Y = 10 * i'])

Hover the title of the PANELS tree
Click the search icon (magnifying glass)
Type the name of a variable to filter on
Should scroll to the variable. Clicking the filter button in the search box should actually filter the results

resolves #49

github-actions[bot] commented 1 week ago

End-to-end Test Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Pending ⏳	Other ❓	Flaky 🍂	Duration ⏱️
6	6	0	0	0	0	0	04:56:05

Detailed Test Results

Name	Status	ms	Flaky 🍂
should default to the correct settings	passed ✅	1966
should return custom settings: Empty configs	passed ✅	279
should return custom settings: Populated configs	passed ✅	107
should be able to load VSCode	passed ✅	785
should only be visible when a supported file type is active: test.groovy	passed ✅	2758
should only be visible when a supported file type is active: test.py	passed ✅	1021

Failed Test Summary

No failed tests ✨

Flaky Test Summary

No flaky tests detected. ✨