deephaven / vscode-deephaven

Deephaven Visual Studio Code Extension
Apache License 2.0
1 stars 0 forks source link

Theme Selection / Configuration #37

Closed bmingles closed 3 days ago

bmingles commented 1 month ago

The vscode extension currently shows the default dark DH theme. We should expose a way to select / configure the theme. It would be really nice, if we could detect which default to use based on whether vscode is using light / dark theme, but at the very least, we should allow the users to explicitly set it somehow.

image
dsmmcken commented 1 month ago

Yeah, looks they have properties and events for that : https://stackoverflow.com/questions/37257911/detect-light-dark-theme-programmatically-in-visual-studio-code/70160793#70160793

bmingles commented 1 month ago

That's good. Will just need a way to set the theme externally in embed widget.

mofojed commented 3 days ago

Fixed with #113