search

deephaven / vscode-deephaven

Deephaven Visual Studio Code Extension
Apache License 2.0
0 stars 0 forks source link

Weird stuff happens on disconnected file run #6

Open chipkent opened 3 weeks ago

chipkent commented 3 weeks ago
  1. Disconnect
  2. Run > Deephaven file

This looks like it is trying to spin up an instance or connect or who knows what. This is unexpected.

See the screenshot in https://docs.google.com/document/d/1ID1vobavzDerUArnFbBMiDPZrtaN6fNooc52uIhSbiY/edit.

bmingles commented 6 days ago

This may have been fixed. If I disconnect and then run a file, it reconnects and produces the result as expected as far as I can tell.

It does re-output any existing server logs on a fresh connection which is consistent with how code studio works if you refresh the page. @mofojed we should think through whether that is the behavior we want when a user is already in vscode and reconnects. Like maybe in certain cases we want to omit stale logs since they would already have them higher up in their output panel.

bmingles commented 6 days ago

I created https://github.com/deephaven/vscode-deephaven/issues/12 to discuss / design any improvements to log output on reconnect.