search

deephaven / web-client-ui

Deephaven Web Client UI
Apache License 2.0
29 stars 31 forks source link

Notebook mouse wheel and new LSP feature #1191

Closed devinrsmith closed 1 year ago

devinrsmith commented 1 year ago

WRT https://github.com/deephaven/web-client-ui/pull/1178 in the context of a notebook:

When I've got a hover pop-up and I use the mouse wheel to scroll in the pop-up, everything works as expected (the mouse wheel action is confined to the limits of the pop-up).

When I'm typing and get a pop-up and I use the mouse wheel to scroll in the pop-up, the mouse wheel action effects the position of my notebook (causing the pop-up to move as well). This is not what I expect to happen. (Is this the "signatureHelp" feature?)

mattrunyon commented 1 year ago

Yes it was triggering on signatureHelp in what you showed me on the call

And on Firefox for Linux in case it is browser/OS dependent

mattrunyon commented 1 year ago

Reproduced on Chrome on Mac. The scrolling of the document happens when I am scrolling the popup past the top or bottom. Scrolling down when it's already at the bottom or up when it's already at the top

Also applies to repl if the command is long enough to scroll

dsmmcken commented 1 year ago

Is this a monaco thing?

mattrunyon commented 1 year ago

Seems to be a bug in monaco that was fixed at some point. When I test on the latest version (0.37.0) on their playground, no issue. When I test on 0.31.1 which we use, the bug exists.

The solution to this is likely just to update monaco