deephaven / web-client-ui

Deephaven Web Client UI
Apache License 2.0
29 stars 31 forks source link

Combobox - tab selection behavior #1900

Open bmingles opened 5 months ago

bmingles commented 5 months ago

The React Spectrum Combobox handles tab key selection as follows

We are finding the 3rd bullet to be confusing to users in the case they have searched for an item and there is only 1 result. Most users would expect hitting tab would select it. As-is, no selection change occurs and it is not intuitive the user would need to hover. We should discuss what the behavior should be here and determine the appropriate place to make any changes (Spectrum or DH)

Note that this will be important for supporting dh.ui deephaven/deephaven-plugins/issues/201 It will also need to be applied to the ACL Editor as well which currently uses the SearchableCombobox component.

mofojed commented 1 month ago

Potentially related Spectrum issues: https://github.com/adobe/react-spectrum/issues/4728 https://github.com/adobe/react-spectrum/issues/4016