search

deephaven / web-client-ui

Deephaven Web Client UI
Apache License 2.0
29 stars 31 forks source link

Treat files as opaque strings to support different file systems #2046

Open mofojed opened 5 months ago

mofojed commented 5 months ago

Related to https://github.com/deephaven/deephaven-core/issues/5068 and https://github.com/deephaven/deephaven-core/pull/5532

Currently Web UI assumes file paths all use a / as a delimiter and start with a slash. On native Windows and in some other situations (such as S3 buckets) that may not necessarily be the case. Instead of assuming there is a / delimiter, we should be treating the file path as an opaque string, and getting the delimiter from the JS API.

mofojed commented 5 months ago

Core side merged initial PR: https://github.com/deephaven/deephaven-core/pull/5532 Should be able to get the file delimiter via the file.separator config path.