feat: ComboBox - @deephaven/components

deephaven / web-client-ui

Deephaven Web Client UI

Apache License 2.0

29 stars 31 forks source link

New ComboBox component in @deephaven/components
Split out some shared logic from Picker since ComboBox is basically a subclass
Deleted old ComboBox component and replaced usage (condition column + row formatting. Also tested to make sure it still works as before)
Updated Styleguide

resolves #2065

BREAKING CHANGE: ComboBox component has been replaced. To migrate to new version:

Passing children is used instead of options prop to define dropdown items. For cases where option value and display are the same, passing an array of values as children will work. For cases where value and display differ, Item elements must be passed as children. e.g. <Item key={value}>{display}</Item> e.g.
```
// values will be used for display + value
const items = useMemo(
() => ['Aaa', 'Bbb', 'Ccc'], 
[]
)
<ComboBox>{items}</ComboBox>
```
```
<ComboBox>
<Item key="aaa">Aaa</Item>
<Item key="bbb">Bbb</Item>
<Item key="ccc">Ccc</Item>
</ComboBox>
```
The spellcheck=false prop is no longer supported or needed
searchPlaceholder and inputPlaceholder props are no longer supported and should be omitted. There is an optional description prop for cases where a descriptive label is desired. There is also a label prop for the primary component label.

Files	Patch %	Lines
...s/components/src/spectrum/picker/usePickerProps.ts	0.00%	13 Missing :warning:
...ages/components/src/spectrum/comboBox/ComboBox.tsx	0.00%	3 Missing :warning:
packages/components/src/spectrum/picker/Picker.tsx	0.00%	1 Missing :warning:
...ebar/conditional-formatting/ColumnFormatEditor.tsx	0.00%	1 Missing :warning:
...sidebar/conditional-formatting/RowFormatEditor.tsx	0.00%	1 Missing :warning:

Patch %

Lines

0.00%

0.00%

0.00%