search

deephaven / web-client-ui

Deephaven Web Client UI
Apache License 2.0
29 stars 31 forks source link

Error when Edited Cell scrolls out of Viewport #2087

Closed dgodinez-dh closed 3 months ago

dgodinez-dh commented 4 months ago

Description

When an Edited Cell is scrolled out the viewport, the table fails with an error "Unable to get ModelIndex for row N". This was discovered while investigating the Enterprise ticket DH-16515. I have only reproduced this scrolling rows, but I suspect it also happens with columns. Tested with both the Legacy and Core+ engines.

Steps to reproduce

  1. Create an InputTable.
  2. Double click on cell to start editing.
  3. While the cell is still in editing mode, scroll it off the screen.

Expected results

The table should scroll like normal.

Actual results

The displays an error "Unable to get ModelIndex for row N"

Additional details and attachments

image

Versions This was found on Enterprise 1.20231218.146 with Core engine 0.33.4

dgodinez-dh commented 4 months ago

Meant to add: In Grid.tsx in renderInputField we call getModelRow which throws an unhandled Error. I suspect the same thing will happen in getModelColumn