deephaven / web-client-ui

Deephaven Web Client UI
Apache License 2.0
28 stars 30 forks source link

IrisGrid - don't stop propagation of scroll events when scroll position is at a boundary #2101

Closed bmingles closed 2 weeks ago

bmingles commented 1 month ago

IrisGrid currently handles scroll events when cursor is over the grid. This behaves as expected when there is scrollable data. The user scrolls and sees the table scroll accordingly. In cases where there are too few rows to scroll or when there are no more rows to scroll in the target direction, no UI change occurs when the user scrolls, and the scroll event is swallowed by the component. This can be confusing if the user is scrolling a long page that happens to contain IrisGrid examples (e.g. deephaven.io). The page scrolls until the cursor ends up over an IrisGrid example in which case the page stops scrolling. If the grid is not scrollable, the lack of UI change gives the impression that the UI has locked up somehow.

Proposed solution would be to only stop propagation of scroll events that would result in scroll position changes.