search

deephaven / web-client-ui

Deephaven Web Client UI
Apache License 2.0
28 stars 30 forks source link

fix: make textValue default to key for Normalized Item #2113

Closed AkshatJawne closed 1 month ago

AkshatJawne commented 1 month ago

Resolves https://github.com/deephaven/web-client-ui/issues/2112

AkshatJawne commented 1 month ago

Ready for re-review

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.64%. Comparing base (e13c9d7) to head (41fb5cb). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2113 +/- ## ========================================== + Coverage 46.60% 46.64% +0.04% ========================================== Files 679 679 Lines 38598 38634 +36 Branches 9779 9794 +15 ========================================== + Hits 17988 18022 +34 - Misses 20558 20560 +2 Partials 52 52 ``` | [Flag](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2113/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2113/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | `46.64% <100.00%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.