deephaven / web-client-ui

Deephaven Web Client UI
Apache License 2.0
28 stars 30 forks source link

fix: Update IrisGridContextMenuHandler getHeaderActions return type to be more permissive #2117

Closed mattrunyon closed 1 month ago

mattrunyon commented 1 month ago

Needed for proper TS in https://github.com/deephaven/deephaven-plugins/pull/522. Otherwise the class complains it can't properly extend IrisGridContextMenuHandler.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.64%. Comparing base (e75e716) to head (ffe68fd). Report is 1 commits behind head on main.

Files Patch % Lines
...d/src/mousehandlers/IrisGridContextMenuHandler.tsx 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2117 +/- ## ======================================= Coverage 46.64% 46.64% ======================================= Files 679 679 Lines 38632 38632 Branches 9792 9792 ======================================= Hits 18020 18020 Misses 20560 20560 Partials 52 52 ``` | [Flag](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2117/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2117/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | `46.64% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.