search

deephaven / web-client-ui

Deephaven Web Client UI
Apache License 2.0
28 stars 30 forks source link

feat: Read file separator from server config #2118

Open mofojed opened 1 month ago

mofojed commented 1 month ago

BREAKING CHANGE: Implementations of FileStorage must now provide the readonly separator: string property

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 48.34437% with 78 lines in your changes missing coverage. Please review.

Project coverage is 46.48%. Comparing base (e75e716) to head (e69d64a). Report is 9 commits behind head on main.

Files Patch % Lines
packages/file-explorer/src/NewItemModal.tsx 0.00% 23 Missing :warning:
...ashboard-core-plugins/src/panels/NotebookPanel.tsx 0.00% 20 Missing :warning:
packages/file-explorer/src/FileExplorer.tsx 61.11% 6 Missing and 1 partial :warning:
packages/code-studio/src/main/AppInit.tsx 0.00% 6 Missing :warning:
...kages/dashboard-core-plugins/src/ConsolePlugin.tsx 16.66% 5 Missing :warning:
...ages/app-utils/src/storage/grpc/GrpcFileStorage.ts 0.00% 4 Missing :warning:
...es/app-utils/src/storage/grpc/GrpcLayoutStorage.ts 0.00% 4 Missing :warning:
packages/file-explorer/src/FileList.tsx 25.00% 3 Missing :warning:
...app-utils/src/storage/grpc/GrpcFileStorageTable.ts 66.66% 2 Missing :warning:
packages/file-explorer/src/useFileStorage.ts 0.00% 2 Missing :warning:
... and 2 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2118 +/- ## ========================================== - Coverage 46.64% 46.48% -0.17% ========================================== Files 679 685 +6 Lines 38632 38487 -145 Branches 9792 9590 -202 ========================================== - Hits 18020 17890 -130 - Misses 20560 20586 +26 + Partials 52 11 -41 ``` | [Flag](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2118/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | `46.48% <48.34%> (-0.17%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.