search

deephaven / web-client-ui

Deephaven Web Client UI
Apache License 2.0
28 stars 30 forks source link

Modify Picker logic responsible for updating options from table #2120

Closed AkshatJawne closed 1 month ago

AkshatJawne commented 1 month ago

In order to remove manual setting of viewport after applying filter proposed here: https://github.com/deephaven/web-client-ui/pull/2096

bmingles commented 1 month ago

@AkshatJawne I think this is the spot where additional filter factories can be applied: https://github.com/deephaven/web-client-ui/pull/2077/files/c0407f68039b9a8e9019756fae0dccdd843a08be#diff-9542f417ebf6c532d214f67543fd42775b65557024e6dee5b4a8d3b8107dbccbR75

Will need to wait on https://github.com/deephaven/web-client-ui/pull/2077 to merge.

AkshatJawne commented 1 month ago

No longer adding filter prop, but refactored the way partition options are updated in the picker in #2110