search

deephaven / web-client-ui

Deephaven Web Client UI
Apache License 2.0
28 stars 30 forks source link

fix: Ref was not being passed through for Picker #2122

Closed mofojed closed 1 month ago

mofojed commented 1 month ago
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 46.59%. Comparing base (8fe9bad) to head (9ea8898).

Files Patch % Lines
packages/components/src/spectrum/picker/Picker.tsx 0.00% 4 Missing :warning:
...ages/components/src/spectrum/comboBox/ComboBox.tsx 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2122 +/- ## ======================================= Coverage 46.58% 46.59% ======================================= Files 681 682 +1 Lines 38431 38441 +10 Branches 9762 9701 -61 ======================================= + Hits 17905 17912 +7 + Misses 20516 20477 -39 - Partials 10 52 +42 ``` | [Flag](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2122/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2122/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | `46.59% <53.84%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mofojed commented 1 month ago

I tested this with DHE, looks to be working correctly.