deephaven / web-client-ui

Deephaven Web Client UI
Apache License 2.0
28 stars 30 forks source link

feat: IrisGridTheme iconSize #2123

Closed mattrunyon closed 1 month ago

mattrunyon commented 1 month ago

This is part of the work needed for #885 that I felt would be better as a separate PR.

Snapshot changes are going to be slightly shifted sort icon and vertical center + slight left shift on tree table arrows.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 10.00000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 46.62%. Comparing base (50f2a6d) to head (7c7840f).

Files Patch % Lines
packages/iris-grid/src/IrisGridRenderer.ts 16.66% 10 Missing :warning:
...ackages/iris-grid/src/IrisGridCellRendererUtils.ts 0.00% 7 Missing :warning:
packages/grid/src/GridRenderer.ts 0.00% 4 Missing :warning:
packages/iris-grid/src/IrisGridIcons.ts 0.00% 3 Missing :warning:
packages/iris-grid/src/IrisGridTextCellRenderer.ts 0.00% 2 Missing :warning:
.../mousehandlers/IrisGridCellOverflowMouseHandler.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2123 +/- ## ========================================== - Coverage 46.62% 46.62% -0.01% ========================================== Files 685 685 Lines 38492 38493 +1 Branches 9590 9589 -1 ========================================== Hits 17948 17948 - Misses 20534 20535 +1 Partials 10 10 ``` | [Flag](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2123/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2123/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | `46.62% <10.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.