search

deephaven / web-client-ui

Deephaven Web Client UI
Apache License 2.0
29 stars 31 forks source link

Advanced Filter contains performance and semantics issues #2124

Open devinrsmith opened 4 months ago

devinrsmith commented 4 months ago

Originally filed https://github.com/deephaven/deephaven-core/issues/5700

The "Advanced Filters > contains" filter is creating an "InvokeCondition" with String#matches(String regex), which is much less efficient than "ContainsCondition".

Furthermore, it looks like "Advanced Filters > contains" is creating a case-insensitive by default query; at a minimum, I think it should provide the option for a user to perform a case-sensitive contains, and ideally would perform a case-sensitive contains by default.

vbabich commented 4 months ago

For GUI filters we always default to case-insensitive. However, adding a "match case" toggle would be reasonable. I've split out the UI change for case-sensitive filtering into a separate ticket - #2136