deephaven / web-client-ui

Deephaven Web Client UI
Apache License 2.0
28 stars 30 forks source link

feat: Add option to disable WebGL rendering #2134

Closed mofojed closed 1 month ago

mofojed commented 1 month ago

Screenshot of when it's disabled/editable (@dsmmcken I think we may need to change Switch styling up here, or the Settings menu background): image

Screenshot of when it's disabled and not editable on the server: image

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 22.50000% with 31 lines in your changes missing coverage. Please review.

Project coverage is 46.62%. Comparing base (989b8ec) to head (c477869). Report is 6 commits behind head on main.

Files Patch % Lines
...ode-studio/src/settings/AdvancedSectionContent.tsx 0.00% 11 Missing :warning:
packages/chart/src/Chart.tsx 0.00% 10 Missing :warning:
packages/chart/src/ChartUtils.ts 44.44% 5 Missing :warning:
packages/chart/src/FigureChartModel.ts 25.00% 3 Missing :warning:
packages/chart/src/ChartModel.ts 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2134 +/- ## ========================================== + Coverage 46.59% 46.62% +0.02% ========================================== Files 682 685 +3 Lines 38441 38489 +48 Branches 9578 9590 +12 ========================================== + Hits 17912 17945 +33 - Misses 20519 20534 +15 Partials 10 10 ``` | [Flag](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2134/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2134/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | `46.62% <22.50%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dsmmcken commented 1 month ago

Is there a follow on ticket for deephaven-express to check this setting?

mofojed commented 1 month ago

@dsmmcken followup ticket: https://github.com/deephaven/deephaven-plugins/issues/612