deephaven / web-client-ui

Deephaven Web Client UI
Apache License 2.0
29 stars 31 forks source link

fix: DH-17454: Wrap Modal in SpectrumThemeProvider #2169

Closed vbabich closed 1 month ago

vbabich commented 1 month ago

Wrap the Modal component attached to document.body in SpectrumThemeProvider.

Had to add zIndex: 0 and position: relative to the SpectrumThemeProvider to fix the issue with DatePicker popovers nested in the Modal rendering behind it.

Screenshot 2024-07-23 at 4 35 35 PM

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.67%. Comparing base (989b8ec) to head (bce2e25). Report is 21 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2169 +/- ## ========================================== + Coverage 46.59% 46.67% +0.07% ========================================== Files 682 692 +10 Lines 38441 38628 +187 Branches 9578 9752 +174 ========================================== + Hits 17912 18028 +116 - Misses 20519 20547 +28 - Partials 10 53 +43 ``` | [Flag](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2169/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2169/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | `46.67% <ø> (+0.07%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.