Closed AkshatJawne closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 46.66%. Comparing base (
1d51585
) to head (d5f9ad6
). Report is 4 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This also disables the self import check from the ignored paths even if the other rules are combined. Not sure the best way around that. You might be able to combine another overrides
inside of the override to turn on the rule for self imports only in those files
Not completely sure what can be done here, I have been experimenting with different configurations, but ultimately, because of the way overrides work, we can only disable the no-restricted-imports
rule for a file path, not a specific import outlined in theno-restricted-imports
Gonna keep experimenting but nothing super promising so far
I believe it should be good now @mattrunyon
The previous version didn't prevent importing from the owning deephaven package when in the spectrum and theme directories. It was actually preventing import a from 'packageName';
Closes #1908