@deephaven/utils - errors when installing in vscode extension

deephaven / web-client-ui

Deephaven Web Client UI

Apache License 2.0

29 stars 31 forks source link

@deephaven/utils - errors when installing in vscode extension #2185

Open bmingles opened 1 month ago

bmingles commented 1 month ago

I attempted to install @deephaven/utils in the vscode-deephaven extension and get a number of errors:

It looks like there are at least 2 classes of errors here:

Incompatible CustomEvent type (presumably due to differences in TypeScript version or tsconfig target)
References to jest. This dependency is not declared in package.json. We may also want to remove the dependency on jest from @deephaven/utils altogether since not all consumers would be using jest as their testing framework.

mofojed commented 1 week ago

References to jest

We should move test code such as TestUtils into it's own directory, and possibly it's own package @deephaven/test-utils to lump a bunch of test utilities together.

bmingles commented 1 week ago

References to jest

We should move test code such as TestUtils into it's own directory, and possibly it's own package @deephaven/test-utils to lump a bunch of test utilities together.

My vote would be a separate package since it's not guaranteed that consumers will use jest at all.

mofojed commented 1 week ago

To clarify my previous comment... files that depend on jest or @testing-library/* or any of our other testing libraries/devDependencies, should not be included in the package build output and should be removed. It may make sense to move them all to a @deephaven/test-utils package (especially TestUtils, which is used by many of our other packages for testing), or simply moved to a folder that is excluded from build output (such as ChartTestUtils, which is not needed in any other package).