Closed mattrunyon closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 46.67%. Comparing base (
a257296
) to head (cb7cb26
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Something I noticed when working on dh.ui databars. I don't think this currently causes any issues in DHC, but it could. If we defined a member field in the proxy model and then set the value, we could end up with the wrong values.
This is only an issue if we directly set a public member. In the current proxy model, we only set via
setField
type functions, so things seem to be fine. Inside of class definitions the proxy is skipped (since the proxy is just returned from the ctor).This change makes setting a member defined in the proxy class work even if you try to do it on the proxy object.