deephaven / web-client-ui

Deephaven Web Client UI
Apache License 2.0
29 stars 31 forks source link

fix: Invalid import in @deephaven/components for webpack #2200

Closed mattrunyon closed 2 weeks ago

mattrunyon commented 3 weeks ago

Fixes #2192

Tested by following steps in the ticket. Created a react app w/ create-react-app and installed @deephaven/components@0.91.1-webpack-fix.0 (alpha build from this PR). It properly started without webpack errors.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.64%. Comparing base (336e1f3) to head (424a5ce).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2200 +/- ## ======================================= Coverage 46.64% 46.64% ======================================= Files 692 692 Lines 38571 38571 Branches 9647 9647 ======================================= Hits 17992 17992 Misses 20568 20568 Partials 11 11 ``` | [Flag](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2200/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2200/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | `46.64% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.