codecov[bot]
commented
2 months ago Codecov Report
Attention: Patch coverage is 12.94118% with 148 lines in your changes missing coverage. Please review.
Project coverage is 46.54%. Comparing base (
aaf4325) to head (716d351).
Additional details and impacted files
```diff @@ Coverage Diff @@ ## feature/python-formatter #2215 +/- ## ============================================================ + Coverage 46.04% 46.54% +0.49% ============================================================ Files 695 698 +3 Lines 39267 38865 -402 Branches 9875 9718 -157 ============================================================ + Hits 18082 18088 +6 + Misses 21085 20766 -319 + Partials 100 11 -89 ``` | [Flag](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2215/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2215/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | `46.54% <12.94%> (+0.49%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fixes #1255
I need to test this doesn't crash if using groovy. Not sure if the ruff version is available without initializing ruff first or what happens if it's unavailable.
Something we should add maybe as part of this PR or a final follow-up to this feature branch is disabling certain/all linting/formatting for the console. One way we might do this is by registering the console w/ a specific URI or URI scheme so we can check it when checking if we should lint. Or include it as a prop to the
MonacoProviderscomponent. This would require some changes to the current setup of setting/using the config onMonacoProvidersstatic members/methods(This might not actually be breaking, it's more just notes for implementing in DHE) BREAKING CHANGE: The app should call
MonacoUtils.initwith agetWorkerfunction that uses the JSON worker in addition to the general fallback worker when adding support for configuring ruff.