deephaven / web-client-ui

Deephaven Web Client UI
Apache License 2.0
29 stars 31 forks source link

fix: Cherry-pick DH-17537: Fix Advanced Filter dialog not showing the values list on tree tables #2235

Closed vbabich closed 2 months ago

vbabich commented 2 months ago

Move isValuesTableAvailable getter from IrisGridTableModel to IrisGridTableModelTemplate to make it availalbe in tree table model. Fixes DH-17537 in enterprise.

Note, this doesn't fix the issue with Advanced Filter on tree tables in Community. JSAPI throws an exception on a treeTable.copy call.

[AdvancedFilterCreator] Unable to open values table Error: java.lang.UnsupportedOperationException: reexport
    at UnsupportedOperationException_0.createError (dh-core.js:1383:10)
    at UnsupportedOperationException_0.initializeBackingError (dh-core.js:1409:46)
    at UnsupportedOperationException_0.Throwable_0 (dh-core.js:1348:8)
    at UnsupportedOperationException_0.Exception_1 (dh-core.js:1433:18)
    at UnsupportedOperationException_0.RuntimeException_1 (dh-core.js:1446:18)
    at new UnsupportedOperationException_0 (dh-core.js:35418:25)
    at Object.lambda$56 (dh-core.js:24457:14)
    at JsTreeTable$lambda$56$Type.fetch_25 [as fetch_1] (dh-core.js:25453:10)
    at Object.$lambda$32_0 (dh-core.js:31972:23)
    at ClientTableState$lambda$32$Type.accept_90 [as accept] (dh-core.js:32707:9)
    at Function.onInvoke_2 (dh-core.js:5068:12)
    at lambda (dh-core.js:174:22)
    at new Promise (<anonymous>)
    at Object.$refetch_2 (dh-core.js:32098:13)
    at JsTreeTable.copy_1 [as copy] (dh-core.js:24514:16)
    at Proxy.valuesTable (IrisGridTableModelTemplate.ts:1519:32)
    at AdvancedFilterCreator.initValuesTable (AdvancedFilterCreator.tsx:212:13)

Filed an issue in Core: https://github.com/deephaven/deephaven-core/issues/6097

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.65%. Comparing base (bebc0f7) to head (5b90e11). Report is 1 commits behind head on release/v0.85.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/v0.85 #2235 +/- ## ================================================= + Coverage 46.61% 46.65% +0.03% ================================================= Files 685 685 Lines 38491 38491 Branches 9776 9776 ================================================= + Hits 17944 17958 +14 + Misses 20537 20481 -56 - Partials 10 52 +42 ``` | [Flag](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2235/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2235/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | `46.65% <100.00%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.