deephaven / web-client-ui

Deephaven Web Client UI
Apache License 2.0
29 stars 31 forks source link

fix: Layout shifts when opening and closing panels from a fresh state #2241

Closed mattrunyon closed 1 month ago

mattrunyon commented 1 month ago

Fixes #1268

This mostly occurs when you have a relatively fresh state. There's a video in the ticket, but if you have just 2 rows then this is frequently triggered. Using incognito mode should give you a fresh state which is affected by this bug.

This fixes both the vertical shift when you open a new panel type (open a notebook from a fresh state or open a table from a fresh layout state) and when you close the last panel in a stack (like in the ticket)

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.42%. Comparing base (ee1bc2f) to head (094cd3b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2241 +/- ## ========================================== - Coverage 46.42% 46.42% -0.01% ========================================== Files 698 698 Lines 38751 38750 -1 Branches 9860 9885 +25 ========================================== - Hits 17991 17990 -1 + Misses 20749 20706 -43 - Partials 11 54 +43 ``` | [Flag](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2241/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2241/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | `46.42% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.