search

deephaven / web-client-ui

Deephaven Web Client UI
Apache License 2.0
29 stars 31 forks source link

fix: DH-17851: Fix snapshot error in TreeTable model when selection extends past viewport #2251

Closed vbabich closed 1 month ago

vbabich commented 1 month ago

IrisGridTreeTableModel.snapshot was attempting to access data outside of the populated viewportData array.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.57%. Comparing base (9e83393) to head (10ae62e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2251 +/- ## ========================================== + Coverage 46.41% 46.57% +0.15% ========================================== Files 698 698 Lines 38767 38767 Branches 9683 9866 +183 ========================================== + Hits 17993 18054 +61 + Misses 20763 20659 -104 - Partials 11 54 +43 ``` | [Flag](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2251/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2251/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | `46.57% <ø> (+0.15%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.