codecov[bot]
commented
1 month ago Codecov Report
Attention: Patch coverage is 5.88235% with 32 lines in your changes missing coverage. Please review.
Project coverage is 46.57%. Comparing base (
229adf0) to head (5732603). Report is 2 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| packages/chart/src/Chart.tsx | 0.00% | 28 Missing :warning: |
| packages/chart/src/ChartModel.ts | 33.33% | 4 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #2255 +/- ## ======================================== Coverage 46.57% 46.57% ======================================== Files 698 698 Lines 38767 38790 +23 Branches 9866 9685 -181 ======================================== + Hits 18054 18065 +11 - Misses 20702 20714 +12 Partials 11 11 ``` | [Flag](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2255/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2255/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | `46.57% <5.88%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Adds new events that enable render-blocking overlays to the chart. The current error pop-up is not sufficient because it still allows the chart to render. This is problematic in the case of webgl because disabling webgl means we don't want the chart rendering at all in case the computer can't handle it.
This is specifically built with https://github.com/deephaven/deephaven-plugins/issues/612 in mind.
Here is an example of the pop-up as implemented in https://github.com/deephaven/deephaven-plugins/pull/934