search

deephaven / web-client-ui

Deephaven Web Client UI
Apache License 2.0
29 stars 31 forks source link

`selectedRanges` for TablePlugins do not update when selection is changed #2274

Open mofojed opened 3 weeks ago

mofojed commented 3 weeks ago

Description

If you create a TablePlugin that listens to selectedRange, it does not update reactively and is just []. Also, panel is no longer passed through. See https://github.com/deephaven/web-client-ui/pull/2181/files which added these props back, but didn't add panel back. By just passing through this.irisGrid.current?.state.selectedRanges, it's not re-rendering the plugin when the selected ranges is actually changed: https://github.com/deephaven/web-client-ui/blob/b5522828a3bc812e7e83440b6d52257a131ce1d2/packages/dashboard-core-plugins/src/panels/IrisGridPanel.tsx#L442