deephaven / web-client-ui

Deephaven Web Client UI
Apache License 2.0
29 stars 31 forks source link

refactor: Change iris-grid reverseType to reverse and deprecate reverseType #2278

Closed mattrunyon closed 2 weeks ago

mattrunyon commented 3 weeks ago

Fixes #2149

This shouldn't be breaking. reverseType prop is deprecated, but still accepted. reverseType in saved states will be changed into reverse and then dropped from the saved state.

Tested this by exporting a layout with a table with reverse from the current DHC release. Then imported the layout to my dev UI and checked the reverse persisted.

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 33.33333% with 14 lines in your changes missing coverage. Please review.

Project coverage is 46.62%. Comparing base (aba019a) to head (802a51c). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...d/src/mousehandlers/IrisGridContextMenuHandler.tsx 0.00% 6 Missing :warning:
packages/iris-grid/src/IrisGrid.tsx 40.00% 3 Missing :warning:
packages/iris-grid/src/IrisGridRenderer.ts 25.00% 3 Missing :warning:
packages/iris-grid/src/IrisGridModelUpdater.tsx 50.00% 1 Missing :warning:
packages/iris-grid/src/IrisGridUtils.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2278 +/- ## ========================================== + Coverage 46.61% 46.62% +0.01% ========================================== Files 696 696 Lines 38756 38745 -11 Branches 9804 9859 +55 ========================================== - Hits 18067 18066 -1 + Misses 20635 20625 -10 Partials 54 54 ``` | [Flag](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2278/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2278/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | `46.62% <33.33%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.