deephaven / web-client-ui

Deephaven Web Client UI
Apache License 2.0
29 stars 31 forks source link

fix: open file blocks logout #2281

Open wusteven815 opened 2 weeks ago

wusteven815 commented 2 weeks ago
wusteven815 commented 2 weeks ago

There seems to be a race condition where if a file is open, AuthPluginPsk gets destroyed before its logout event is received. This delays the state change that causes a remount, so that the logout event is reached in time.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.60%. Comparing base (5ebc195) to head (d99b4a5).

Files with missing lines Patch % Lines
packages/app-utils/src/components/AppBootstrap.tsx 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2281 +/- ## ========================================== - Coverage 46.60% 46.60% -0.01% ========================================== Files 704 704 Lines 38963 38964 +1 Branches 9914 9729 -185 ========================================== Hits 18158 18158 - Misses 20794 20795 +1 Partials 11 11 ``` | [Flag](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2281/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/deephaven/web-client-ui/pull/2281/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven) | `46.60% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=deephaven#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.