Component props and defaultProps not declared properly in TypeScript

deephaven / web-client-ui

Deephaven Web Client UI

Apache License 2.0

29 stars 31 forks source link

Component props and defaultProps not declared properly in TypeScript #426

Open dsmmcken opened 2 years ago

dsmmcken commented 2 years ago

The follow components should be using this method for typing props and default props

LinkerOverlayContent
LinkerLink
Tooltip
Popper
Menu
Dropdownmenu
ContextMenu
SelectValueList
SearchInput
ItemListItem
ItemList
HierarchicalCheckboxMenu
DraggableItemList
DebouncedSearchInput
CustomTimeSelect
ComboBox
Collapse
AutoCompleteInput

dsmmcken commented 2 years ago

Discovered when tooltips started failing because of a new onExited defaultProp, and discovered they are not actually being set.

Audited and found the above by search for "static defaultProps"

mofojed commented 2 years ago

The default value is being set so this is not as bad as previously thought. The problem is TypeScript isn't properly type checking it, as some properties are not marked optional when they have a default value.