deephealthproject / pyecvl

Python wrapper for the ECVL.
MIT License
4 stars 2 forks source link

DLDataset constructor: augs should not be optional #65

Closed simleo closed 2 years ago

simleo commented 2 years ago

Our DLDataset constructor "allows" to specify ony the file name and the batch size, but in that case crashes while trying to call a nonexistent no-arg constructor for DatasetAugmentations:

>>> d = ecvl.DLDataset("/ecvl/examples/data/mnist/mnist_reduced.yml", 10) 
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.6/dist-packages/pyecvl-0.12.1-py3.6-linux-x86_64.egg/pyecvl/support_eddl.py", line 137, in __init__
    augs = _ecvl.DatasetAugmentations()
TypeError: __init__(): incompatible constructor arguments. The following argument types are supported:
    1. pyecvl._core.ecvl.DatasetAugmentations(arg0: List[pyecvl._core.ecvl.Augmentation])
    2. pyecvl._core.ecvl.DatasetAugmentations(arg0: pyecvl._core.ecvl.DatasetAugmentations)

It needs to be changed so that the third argument is required, like in the C++ API.