search

deepimagej / models

4 stars 5 forks source link

Fix weights typo and formats #2

Closed oeway closed 4 years ago

oeway commented 4 years ago

This PR fixes:

  1. the weights typo
  2. add format_version
  3. changes weights from a dictionary to a list (see https://github.com/bioimage-io/configuration/pull/25)
  4. change sha256 to null

BTW, I think you can zip the ./variables and store it on github release, then paste the url to weights/source, you can then generate the sha256. This would require to change the way you process in deep imagej though, but I think it would worth since then you can support multiple weights.

esgomezm commented 4 years ago

We will try to store the weights like that but we need to check how it fits with the concept of bundled models and easy installation of the models. At the moment it is becoming quite difficult to follow all the updates at the zoo, we are trying our best!