search

deepimagej / models

4 stars 5 forks source link

Verify bioimageio manifest with --auto-convert #22

Closed FynnBe closed 3 years ago

FynnBe commented 3 years ago

--auto-convert is a new option that converts model spec changes if automatically possible. This allows for slightly outdated models to pass the validation if no breaking changes have been introduced, because currently the validation is always done expecting the latest format version.

fixed problems with the fru-net_sev_segmentation model:

remaining problems with the fru-net_sev_segmentation model:

constantinpape commented 3 years ago 
* spec 0.3.2 expects `documentation` to be a relative path to a markdown file, thus https://cbia.fi.muni.cz/research/segmentation/fru-net.html is invalid

Could we change that and also accept html in the spec?

FynnBe commented 3 years ago

https://github.com/bioimage-io/spec-bioimage-io/pull/97/commits/3daf4e269735c26e14daf28cf8e856d8d2e63633 in https://github.com/bioimage-io/spec-bioimage-io/pull/97 fixes the documentation problem for validation (not rendering on the website yet)

constantinpape commented 3 years ago

@FynnBe can you rerun the new autoconvert that generates the documentation here?

FynnBe commented 3 years ago

@FynnBe can you rerun the new autoconvert that generates the documentation here?

the autoconvert for now only make the model spec valid (and saving the original content in config, but does not write out any generated documentation .md file. With https://github.com/bioimage-io/spec-bioimage-io/pull/97 merged the tests here should pass (if other license issues have been manually fixed like in this PR for one model)

FynnBe commented 3 years ago

@esgomezm please approve to run CI