deepimagej / models

4 stars 5 forks source link

Missing models to upload #31

Closed esgomezm closed 2 years ago

esgomezm commented 2 years ago

Hi @crtorreg and @xion16lm

I'm reviewing which are the models that still need to be updated/uploaded to the bioimage model zoo using the uploader. Here I let you the list from what I saw. Could you please take a look and update them?

Note that the basic package we need to upload for deepImageJ models (until we can call the bioengine packager) is the following one:

Now there is the spec checker for the uploads and most probably none of our models passes the spec because we are missing the batch dimensions and the channel dimension (when it is one) in all the numpy arrays. So, if you are uploading a new model (like UNet2DGlioblastomaSegmentation), please change this.

@oeway:

crtorreg commented 2 years ago

Hi @esgomezm,

I am going to take a look one by one now!

esgomezm commented 2 years ago

OK! Thank you @crtorreg !

Please, note that whenever we make a new commit, GitHub workflows check that the model specs are correct. If this workflow does not pass the test (red cross in the image), then, the json file is not updated and therefore, we won't see the changes in the deepImageJ installer:

Screenshot 2021-10-19 at 10 24 23

At the moment the validator has some errors (see issue here), but once this is solve, please check that your changes are correct.