search

deepimagej / models

4 stars 5 forks source link

Updating bioimageio workflow #37

Closed FynnBe closed 2 years ago

FynnBe commented 2 years ago

@oeway is this (generation of a manifest.json) still needed? https://github.com/deepimagej/models/blob/49afaec2596d08dea3462cfe1ed02974ec0e68fa/.github/workflows/compile-manifest.yml#L24-L41

oeway commented 2 years ago

We don't need that anymore, but not sure if deepimagej uses any of the generated file on gh-pages. @esgomezm may clarify this?

Note that if you remove that, you may want to also remove the deployment step for built-output and also perhaps make sure the dependencies for the validator is installed.

FynnBe commented 2 years ago

proposed workflow update: https://github.com/deepimagej/models/pull/38

esgomezm commented 2 years ago

Hei

We don't need that anymore, but not sure if deepimagej uses any of the generated file on gh-pages. @esgomezm may clarify this?

Sorry, yes, we are using it. I thought we were on a different repository. We parse this file in the plugin to download some models that we have as examples and "under control"

https://github.com/deepimagej/models/blob/gh-pages/manifest.bioimage.io.json

FynnBe commented 2 years ago

ok, as the workflow is currently failing (last run: https://github.com/deepimagej/models/runs/4854793126?check_suite_focus=true), could you fix it? Feel free to move https://github.com/bioimage-io/bioimage-io-models/blob/main/utils/compile_model_manifest.py over here if you do need it as this is not used anywhere else and the whole https://github.com/bioimage-io/bioimage-io-models repository is deprecated...

If this is not urgent we could also just add another workflow (see https://github.com/deepimagej/models/pull/38) just to get the validation of the collection RDF going again (It currently fails, I would like to propose some changes so it will pass again...)

FynnBe commented 2 years ago

I will leave the compile-manifest.yml untouched in #38 then...