deepimagej / models

4 stars 5 forks source link

Duplicate model entries #47

Open FynnBe opened 1 year ago

FynnBe commented 1 year ago

Some models, e.g. are linked to the bioimage.io collection via https://github.com/deepimagej/models/blob/master/manifest.bioimage.io.yaml and a zenodo record. As discussed previously we should prefer the zenodo records to host models and remove the entries in this manifest here.

carlosuc3m commented 1 year ago

@lmoyasans @esgomezm we should delete the models from here when possible and upload them through the bioimage.io uploader. The models where kep in the manifest.yaml as legacy from the previous DIJ installer which parsed that file to retrieve the models. Since https://github.com/deepimagej/deepimagej-plugin/commit/fb0fa726dd3cd4b0c4b469bc5a602af1dee927f0 the models can be downloaded in the same way as the bioimage.io packager. So the manifest yaml is not needed to download models

esgomezm commented 1 year ago

Hi there, this has been done already as soon as the models were correctly uploaded (there are many open pull requests) such as the cases of FRUNEt, ZCDL4M unets, pancreatic cells etc. which have already disappeared from the main manifest yaml of deepImageJ. Still when removing those models from the yaml, please, for our internal record, keep them updated here https://github.com/deepimagej/models/blob/master/manifest.bioimageio_dij_install_model.yaml.

carlosuc3m commented 1 year ago

I have created a list with the errors that I have seen in each of the models. A couple of the DIJ ones have errors coming from the zipped model, as it is not up to date with the model defined in the model card. If we keep the redundancy of the zipped model, it is important to make sure they are fine as it could be a source of errors