arm64:phytnetled: phytium: Add link/act led driver for 10G mac

deepin-community / kernel

deepin linux kernel

https://www.deepin.org

Other

21 stars 58 forks source link

arm64:phytnetled: phytium: Add link/act led driver for 10G mac #299

Closed yuanxia0927 closed 2 months ago

yuanxia0927 commented 2 months ago

That patch povides support for phytium 10G mac link/act led control according port link and active state.

deepin-ci-robot commented 2 months ago

Hi @yuanxia0927. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

opsiff commented 2 months ago

很不幸这里需要修改一下

2024-06-27T06:34:28.2991721Z drivers/char/phytnetled/phytnet_led.c: In function ‘net_led_remove’: 2024-06-27T06:34:28.3069360Z drivers/char/phytnetled/phytnet_led.c:300:13: error: the comparison will always evaluate as ‘true’ for the address of ‘dev’ will never be NULL [-Werror=address] 2024-06-27T06:34:28.3072641Z 300 | if (&pdev->dev) 2024-06-27T06:34:28.3073421Z AR drivers/gpu/drm/tests/built-in.a 2024-06-27T06:34:28.3074859Z | ^ 2024-06-27T06:34:28.3075781Z In file included from ./include/linux/of_device.h:5, 2024-06-27T06:34:28.3076862Z from ./include/linux/of_platform.h:10, 2024-06-27T06:34:28.3077910Z from drivers/char/phytnetled/phytnet_led.c:8: 2024-06-27T06:34:28.3079675Z ./include/linux/platform_device.h:27:25: note: ‘dev’ declared here 2024-06-27T06:34:28.3211107Z 27 | struct device dev; 2024-06-27T06:34:28.3213548Z | ^~~ 2024-06-27T06:34:28.4173932Z cc1: all warnings being treated as errors 2024-06-27T06:34:28.4312665Z make[5]: [scripts/Makefile.build:243：drivers/char/phytnetled/phytnet_led.o] 错误 1 2024-06-27T06:34:28.4319941Z make[4]: [scripts/Makefile.build:480：drivers/char/phytnetled] 错误 2 2024-06-27T06:34:28.4321303Z make[4]: 正在等待未完成的任务.... 2024-06-27T06:34:28.4609792Z make[3]: [scripts/Makefile.build:480：drivers/char] 错误 2 2024-06-27T06:34:28.4610840Z make[3]: *** 正在等待未完成的任务....

opsiff commented 2 months ago

/ok-to-test

deepin-ci-robot commented 2 months ago

deepin pr auto review

关键摘要:

在led_control函数中，phytnet_led->act_val的赋值应该在gpiod_set_value之前，以确保正确的LED状态。
led_blink函数中，应该检查phytnet_led->act是否为NULL，然后再调用gpiod_set_value。
led_init_and_control函数中的gpio_init调用应该在of_ndev_init和acpi_ndev_init之后，以确保正确的GPIO初始化顺序。
net_led_probe和net_led_remove函数中，应该检查phytnet_led是否为NULL，然后再进行操作。
led_control函数中的msleep调用可能需要根据实际需求调整时间间隔，以达到预期的LED闪烁效果。

是否建议立即修改: 是