Closed MingcongBai closed 2 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign yukarichiba for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
/ok-to-test
关键摘要:
pdev->device
的检查使用了硬编码的设备ID,这可能不利于代码的可维护性和可扩展性。建议使用设备ID的常量或枚举类型。pr_warn
,这是一个旧式的打印函数,建议使用dev_err
或dev_info
等更现代的日志函数。pdev->device
可能需要考虑是否有权限检查,以确保不会访问到非预期的设备信息。-EINVAL
,这是一个不具体的错误码,建议使用一个更具描述性的错误码,或者定义一个错误码常量。是否建议立即修改: 是
…RCED_LEVEL_AUTO
Some devices have stablity issue on AMD_DPM_FORCEDLEVEL* except AMD_DPM_FORCED_LEVEL_AUTO. Don't use these AMD_DPM_FORCED_LEVEL
Bug: https://pms.uniontech.com/bug-view-203541.html
Signed-off-by: hongao hongao@uniontech.com Change-Id: I84069c201713a4f86a3d492e35a86bd5f59b2d54 (cherry picked from commit 669fa93ed09c5c27233bc8ad0c9ba1a125ae4e96)