Closed Avenger-285714 closed 1 month ago
关键摘要:
nvkm_firmware_ctor
函数中,fw->img
的内存分配应该使用kmalloc
而不是dma_alloc_coherent
,以避免潜在的DMA错误。dma_map_single
函数的使用应该检查返回值,以确保内存映射成功。kfree
函数在内存映射失败时被调用,但是没有相应的注释说明为什么需要释放内存。sg_init_one
函数的使用应该确保fw->img
已经被正确映射到设备。是否建议立即修改: 是
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign tsic404 for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Reverts deepin-community/kernel#315