Closed sterling-teng closed 1 month ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign tsic404 for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
/lgtm
关键摘要:
loongarch/configs/loongson3_defconfig
文件中,将CONFIG_DEBUG_INFO_DWARF4
更改为CONFIG_DEBUG_INFO_DWARF4
可能会影响调试信息格式,需要确认是否有特定原因需要这样做。loongarch/include/asm/numa.h
文件中,移除了NODES_PER_FLATMODE_NODE
宏定义,需要验证这一改动是否不会影响其他相关的代码部分。loongarch/kernel/acpi.c
文件中,修改了set_processor_mask
函数以处理更少的CPU核心,这可能会影响系统管理器和启动脚本的行为,需要验证这一改动是否符合预期。loongarch/kernel/irq.c
文件中,添加了新的Hibernation条件判断,需要验证这些更改是否正确处理了 resume 和 hibernate 命令。loongarch/kernel/relocate.c
文件中,修改了KASLR的配置,需要验证这一改动是否不会影响系统的其他部分。loongarch/kernel/smp.c
文件中,修改了CPU核心的初始化逻辑,需要验证这一改动是否正确处理了CPU核心的枚举和初始化。drivers/irqchip/irq-loongson-eiointc.c
文件中,修改了early_cpu_to_node
函数的调用方式,需要验证这一改动是否正确处理了节点映射。是否建议立即修改: 是
这些更改涉及到系统配置、编译选项、内核逻辑和驱动程序,需要仔细验证每个更改是否符合预期行为,并确保不会引入新的错误或兼容性问题。特别是loongarch/configs/loongson3_defconfig
和loongarch/include/asm/numa.h
的更改可能会影响系统稳定性,需要特别注意。
Hi @sterling-teng. Thanks for your PR.
I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with
/ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.Once the patch is verified, the new status will be reflected by the
ok-to-test
label.I understand the commands that are listed here.