search

deepjavalibrary / djl

An Engine-Agnostic Deep Learning Framework in Java
https://djl.ai
Apache License 2.0
4.12k stars 654 forks source link

SentencePiece Support for Windows #1411

Closed Lundez closed 2 years ago

Lundez commented 2 years ago

Description

Let's add support for Windows for SentencePiece. It is already supported upstream in the library.

I think changing https://github.com/deepjavalibrary/djl/blob/master/.github/workflows/native_s3_sentencepiece.yml to include a windows build should be enough?

Who will benefit from this enhancement? Windows users.

frankfliu commented 2 years ago

@Lundez Thanks for reporting this issue. We will prioritize this feature. Would you mind create a PR to add windows support in DJL?

frankfliu commented 2 years ago

@Lundez by the way, we are adding Huggingface tokenizers support: https://github.com/deepjavalibrary/djl/pull/1406

Lundez commented 2 years ago

@Lundez by the way, we are adding Huggingface tokenizers support: https://github.com/deepjavalibrary/djl/pull/1406

That's amazing news! I hope to see it soon 😍

Regarding setting up a PR - I'll try to get that done by the weekend

frankfliu commented 2 years ago

Fixed with #1412