search

deepjyoti30 / QuickWall

Set latest wallpapers from Unsplash from the commandline
https://deepjyoti30.github.io/quickwall
MIT License
189 stars 8 forks source link

KDE - lockscreen wallpaper #11

Closed Mazurel closed 4 years ago

Mazurel commented 4 years ago

Small patch to set KDE lock screen wallpaper if user wants it. Also I have added logger (based on nitrogen) for KDE. It is tested and it works well.

deepjyoti30 commented 4 years ago

Hey @Mazurel I think we should rather add a flag that can be passed when calling QuickWall rather than interrupting the user for lockscreen everytime.

Something like QuickWall --set-lockscreen

Mazurel commented 4 years ago

Hey, I have tried to make it as you wished, I hope you like it. It works via --set-lockscreen and is disabled by default.

deepjyoti30 commented 4 years ago

Okay, I will look into it later when I get time. Thanks for the PR

deepjyoti30 commented 4 years ago

Hey @Mazurel I will check the PR and merge it soon. Was busy this few days.

deepjyoti30 commented 4 years ago

Hey @Mazurel I checked the code.

If we pass the lockscreen option with some wallpaper setter like nitrogen then I think it will cause an issue because of line 56 in setter.py

return self.setter(True) this line, if called with any wallpaper setter other than KDE will raise an error. We need to add a check to see if KDE is being selected.

Something like if self.lockscreen and self.setter_type == 'kde': # return with True.

Please make those changes.

Mazurel commented 4 years ago

Indeed there was a problem there, I have fixed it by adding variable which stores lockscreen compatible setters. I think that now there shouldn't be any errors.