deepjyoti30 / startpage

A minimal starpage for Chrome and Firefox
MIT License
625 stars 85 forks source link

Change colors of titles from JSON config #12

Closed reesericci closed 4 years ago

reesericci commented 4 years ago

Currently I have to go into the CSS to change the title colors if I have custom titles or want the color changed of a default. I think it would be a nice addition if it was possible to change the color of the titles from the JSON config but also have an auto option. Something like this: Auto:

{
  "name": "title",
  "color": "auto",
   "links" [{}]
},

Custom:

{
  "name": "title",
  "color": "#FFFFF",
   "links" [{}]
},
deepjyoti30 commented 4 years ago

Yes, I think that's one of the things I will add in the next release along with #8

reesericci commented 4 years ago

Cool!

reesericci commented 4 years ago

jQuery has a css modifier: https://api.jquery.com/css/

deepjyoti30 commented 4 years ago

@reesericci I've pushed the changes, try them if you want to and report back in case you face any issues.

reesericci commented 4 years ago

Ok will do

reesericci commented 4 years ago

I feel like if I say "green" it should pick from a preset green. Or if I say red, pick a preset red. Otherwise, use the hex

deepjyoti30 commented 4 years ago

@reesericci You mean you want to keep green as a custom variable that should be referenced when you use it??

Why not just use the hex instead??

reesericci commented 4 years ago

I want to be able to pick from preset colors. As well as have the option to use a hex.

deepjyoti30 commented 4 years ago

@reesericci Lemme think what a good way would be to implement that. For now I'm trying to add support for shortcuts from the search bar as requested in #8

deepjyoti30 commented 4 years ago

@reesericci I think it would be too much of an overhaul to add support to define color variables that can be later referrenced.

Currently, the supported colors are hex and CSS predefined colors.

NicTanghe commented 4 years ago

Hex is perfectly fine.

reesericci commented 4 years ago

Ok then, closing now