search

deepjyoti30 / startpage

A minimal starpage for Chrome and Firefox
MIT License
630 stars 86 forks source link

Settings Page #22

Closed iisGmoney closed 4 years ago

iisGmoney commented 4 years ago

This is less of an issue and more of a suggestion, it would be nice to add a settings page, so that you can have settings accessible in a way where anyone who doesn’t know how to edit the .json file can mess with the settings without breaking it

deepjyoti30 commented 4 years ago

@iisGmoney Thanks for the suggestion, this is what I had in mind from the beginning but then I did updated the README for a while suggesting it's a headache building a GUI setting page, especially for those squares.

For a while I thought I will not add any settings page at all but then I thought adding a json editor would be a nice hack since without a settings page I can't push the extension to web stores and so I added that json editor. I will still consider your suggestion though but seriously, it's a real mess for me designing that atm.

reesericci commented 4 years ago

I think a JSON editor is fine and all the options are well-documented, as well as being pretty self-explanatory.

reesericci commented 4 years ago

@iisGmoney close? @deepjyoti30 wontfix label

reesericci commented 4 years ago

@deepjyoti30 just filed a PR making some improvements to settings #29