search

deepjyoti30 / startpage

A minimal starpage for Chrome and Firefox
MIT License
625 stars 85 forks source link

AMO Link Broken #24

Closed reesericci closed 4 years ago

reesericci commented 4 years ago

The link to AMO for the extension is broken. (README)

deepjyoti30 commented 4 years ago

@reesericci Yup, I'm aware of that. The extension was removed by the Firefox team because of a bit of code.

The code was that I was updating a div with innerHTML which is not safe and I understand that.

I did think I would reupload after changing the innerHtml part to innerText but then recently I added support to add colors from the config where I had to use something similar in order to chnage the color.

I did try to go for alternatives but it was unavoidable and so I think I won't be able to upload it to AMO anymore since it will end up getting rejected anyway.

The commit is https://github.com/deepjyoti30/startpage/commit/4b521b5a603219eaf622e77d19dec42bc9feb6cc in case you wanna check the source.

reesericci commented 4 years ago

That's a bummer, I know jQuery can change the css.

reesericci commented 4 years ago

25 Filed a PR to remove the link from the README

reesericci commented 4 years ago

Merged, closed for now