search

deepjyoti30 / startpage

A minimal starpage for Chrome and Firefox
MIT License
625 stars 85 forks source link

Settings improvements #29

Closed reesericci closed 4 years ago

reesericci commented 4 years ago

@deepjyoti30 I made some improvements to settings:

  1. Make --settings a valid query to open settings. It's kinda un-intuitive to type --setting so I fixed it by making both valid.
  2. Add a settings cog. I added a settings cog in the bottom right that can open and close settings.
reesericci commented 4 years ago

Scrot: image

reesericci commented 4 years ago

@deepjyoti30 take a look!

deepjyoti30 commented 4 years ago

@reesericci Will take a look, perhaps in the weekend.

reesericci commented 4 years ago

ok

deepjyoti30 commented 4 years ago

@reesericci The cog looks well and good but considering that we don't even have a proper settings UI, I don't think it will be a good idea to add it. Also, it takes away the whole minimal look.

We can perhaps make it optional and keep it hidden by default.

reesericci commented 4 years ago

yes, please make it optional (its a bit over my head though.). Modify the PR to add an option to enable/disable the cog. Or only show it when its hovered over. @deepjyoti30

reesericci commented 4 years ago

@deepjyoti30

deepjyoti30 commented 4 years ago

@reesericci Cool. Also regarding the settings icon, since I already added a key binding, I think we can skip it?

reesericci commented 4 years ago

is it possible to make the icon optional in the config? (i like the icon, and I think others will too.) I don't know how to make a config entry, but I will learn soon! @deepjyoti30

deepjyoti30 commented 4 years ago

@reesericci Cool, I will merge this and make the changes required.

reesericci commented 4 years ago

ok np

reesericci commented 4 years ago

merge?

reesericci commented 4 years ago

@deepjyoti30 reviewed

reesericci commented 4 years ago

yay!!!!