deepjyoti30 / startpage

A minimal starpage for Chrome and Firefox
MIT License
625 stars 85 forks source link

Add manifest.json to release zip #34

Closed reesericci closed 3 years ago

reesericci commented 3 years ago

Add a manifest.json for firefox in the release zip for easy uploading to addons.mozilla.org to remove the step of building.

reesericci commented 3 years ago
image
reesericci commented 3 years ago

I think you will have to do the web-ext building per release to generate this manifest.json

deepjyoti30 commented 3 years ago

@reesericci Just checked. The issue was that in the latest release, I zipped the directory of startpage and not just the contents. I'll update the release files.

deepjyoti30 commented 3 years ago

@reesericci Updated the release!

reesericci commented 3 years ago

one sec lemme try it

reesericci commented 3 years ago

I just downloaded the september release and getting the same error. Try running web-ext build on the zip and uploading the zip that it creates into the release.

reesericci commented 3 years ago

@deepjyoti30

deepjyoti30 commented 3 years ago

@reesericci I see, the issue was at my end. I updated the zip. It should work now!

reesericci commented 3 years ago

It worked! Updated the wiki