search

deepjyoti30 / startpage

A minimal starpage for Chrome and Firefox
MIT License
625 stars 85 forks source link

Fixed all issues and added nord theme #36

Closed WitherCubes closed 3 years ago

WitherCubes commented 3 years ago

I fixed all my issues from last pull request.

reesericci commented 3 years ago

There is currently no way to select a theme. Which means, this will override the default color scheme. There needs to be a way to pick between black and nord for this to work. @deepjyoti30 what do you say?

deepjyoti30 commented 3 years ago

@reesericci Yeah. If I merge this PR, it'd override the default colorscheme.

I think the config already allows changing colorschemes? If the end user wants nord theme, they can just copy @WitherCubes config and apply it and everything will change?

reesericci commented 3 years ago

Doesn't this change the background though? I don't think its currently possible to change the background in the config. @WitherCubes made changes to the core css files, and as such overrides the theme. If somebody wants to use this, they would have to build it themselves with the new css.

reesericci commented 3 years ago
image

yup core files being changed @deepjyoti30

deepjyoti30 commented 3 years ago

@reesericci It does make sense to allow more theming options. I think we can open an issue and discuss about it over there instead of this PR?! Feel free to open one!

WitherCubes commented 3 years ago

We can give an option for the user to download the default theme or the nord theme.